Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-2045] Refactor index and add queue event parser helper #1259

Merged
merged 14 commits into from
Dec 5, 2024

Conversation

MarcoPonchia
Copy link
Collaborator

@MarcoPonchia MarcoPonchia commented Nov 28, 2024

Depends on: #1257

List of Changes

  • Refactor index
  • Add queue event parser helper

Motivation and Context

Mange webinar subscription and cancellation event in sqs queue handler

How Has This Been Tested?

Automatic test and manually

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MarcoPonchia MarcoPonchia self-assigned this Nov 28, 2024
Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: 639b788

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@marcobottaro marcobottaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changeset is missing and you should also fix a typo in the changeset file merged with the previous PR:

<+>UTF-8
===================================================================
diff --git a/.changeset/stale-wombats-cover.md b/.changeset/stale-wombats-cover.md
--- a/.changeset/stale-wombats-cover.md	(revision c6a3f41dc53fd8b8f3eeda045e0588ad1aec7a8d)
+++ b/.changeset/stale-wombats-cover.md	(date 1732877075484)
@@ -2,4 +2,4 @@
 "active-campaign-client": minor
 ---
 
-Refactor active campaign pacakge and create index file
+Refactor Active Campaign package and create index file

@MarcoPonchia MarcoPonchia changed the title Refactor index and add queue event parser helper [DEV-2045] Refactor index and add queue event parser helper Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Branch is not up to date with base branch

@MarcoPonchia it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

@MarcoPonchia MarcoPonchia marked this pull request as ready for review December 3, 2024 14:41
Copy link

dpulls bot commented Dec 5, 2024

🎉 All dependencies have been resolved !

@github-actions github-actions bot removed the changeset label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-2045

@MarcoPonchia MarcoPonchia merged commit b9003b6 into main Dec 5, 2024
11 checks passed
@MarcoPonchia MarcoPonchia deleted the add-webinars-event-to-queue-handler branch December 5, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants