[DEV-2055] Add ssm to ac client #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istSubscription.test.ts Co-authored-by: marcobottaro <[email protected]>
…istSubscription.test.ts Co-authored-by: marcobottaro <[email protected]>
Co-authored-by: Marco Ponchia <[email protected]>
…webinars-event-to-queue-handler
🦋 Changeset detectedLatest commit: a87dba2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MarcoPonchia
requested review from
marcobottaro,
tommaso1 and
a team
as code owners
tommaso1
requested changes
Dec 5, 2024
| ssmClient: SSMClient, | ||
| fallbackValue?: string | ||
| ) { | ||
| // TODO: remove fallbackValue only for testing purposes should be substituted by a mock function |
There was a problem hiding this comment.
Suggested change
| // TODO: remove fallbackValue only for testing purposes should be substituted by a mock function |
For me it's fine to have a default value
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-2055 |
tommaso1
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Add SSM Client to manage Active Campaign secrets
Motivation and Context
Add SSM Client to manage Active Campaign secrets
How Has This Been Tested?
Manually
Screenshots (if appropriate):
Types of changes
Checklist: