[DEV-2017] Resync user on active campaign #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0bbe156 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MarcoPonchia
requested changes
Dec 6, 2024
packages/active-campaign-client/src/helpers/getUserFromCognito.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marco Ponchia <[email protected]>
Co-authored-by: Marco Ponchia <[email protected]>
Co-authored-by: Marco Ponchia <[email protected]>
Co-authored-by: Marco Ponchia <[email protected]>
6 tasks
MarcoPonchia
approved these changes
Dec 17, 2024
marcobottaro
requested changes
Dec 17, 2024
packages/active-campaign-client/src/handlers/resyncUserHandler.ts
Outdated
Show resolved
Hide resolved
packages/active-campaign-client/src/handlers/resyncUserHandler.ts
Outdated
Show resolved
Hide resolved
| await prevPromise; | ||
| try { | ||
| const result = await addContactToList(cognitoId, webinarId); | ||
| console.log('Add contact to list result:', result, webinarId); // TODO: Remove after testing |
There was a problem hiding this comment.
I think you should remove the TODOs
| import { DynamoDBClient, QueryCommand } from '@aws-sdk/client-dynamodb'; | ||
| import { APIGatewayProxyResult } from 'aws-lambda'; | ||
|
|
||
| export async function fetchSubscribedWebinarsFromDynamo( |
There was a problem hiding this comment.
What about fetchWebinarSubscriptions or get...? Does fromDynamo suffix is relevant?
Co-authored-by: marcobottaro <[email protected]>
Co-authored-by: marcobottaro <[email protected]>
Branch is not up to date with base branch@tommaso1 it seems this Pull Request is not updated with base branch. |
marcobottaro
approved these changes
Dec 18, 2024
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-2017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the sync with active campaign somehow fails this lambda takes the user, deletes it to be sure the state is reset, and then syncs it back again
List of Changes
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: