Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-1336] Fix change password page and changed password page #608

Merged
merged 45 commits into from
Feb 16, 2024

Conversation

marcobottaro
Copy link
Collaborator

@marcobottaro marcobottaro commented Feb 6, 2024

List of Changes

Fix change password page and changed password page
This PR depends on #601, #604 , #605

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

image

image

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@marcobottaro marcobottaro self-assigned this Feb 6, 2024
Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: 25ffc0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nextjs-website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marcobottaro marcobottaro changed the base branch from main to DEV-1335-reset-passoword-request February 6, 2024 15:17
tommaso1
tommaso1 previously approved these changes Feb 8, 2024
@kin0992
Copy link
Contributor

kin0992 commented Feb 15, 2024

Take note that these steps can cause some issues (we need to investigate if it's true):

  • insert the email address with a typo (e.g. mario instead of marco)
  • the next screen shows me the email address inserted in bold and I see the error
  • come back to the previous step, using the "Torna indietro" button
  • I fix the email address -> in the query param there is the old email address, the one with the typo.
    If that value is used then, we could have some issues

apps/nextjs-website/src/messages/it.json Outdated Show resolved Hide resolved
apps/nextjs-website/src/messages/it.json Outdated Show resolved Hide resolved
@marcobottaro
Copy link
Collaborator Author

Take note that these steps can cause some issues (we need to investigate if it's true):

  • insert the email address with a typo (e.g. mario instead of marco)
  • the next screen shows me the email address inserted in bold and I see the error
  • come back to the previous step, using the "Torna indietro" button
  • I fix the email address -> in the query param there is the old email address, the one with the typo.
    If that value is used then, we could have some issues

The route replace was useless. I removed it, so the problem is solved. Thanks!

Copy link
Contributor

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-1336

Copy link
Contributor

📦 Next.js Bundle Analysis for nextjs-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

1 similar comment
Copy link
Contributor

📦 Next.js Bundle Analysis for nextjs-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@kin0992 kin0992 removed their request for review February 16, 2024 10:29
@marcobottaro marcobottaro merged commit 532f1d6 into main Feb 16, 2024
11 checks passed
@marcobottaro marcobottaro deleted the DEV-1336-change-password branch February 16, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants