Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-1382] - Create Certificate for CMS Strapi #636

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

maurodandrea
Copy link
Collaborator

@maurodandrea maurodandrea commented Feb 13, 2024

Create Certificate for CMS Strapi
Depends on #640

List of Changes

Modify Terraform file Certificate

Motivation and Context

Create Certificate for CMS Strapi

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change not requires a change to the documentation.
  • I have updated the documentation accordingly.

add-certificate-and-var-cms
add-dns-zone-cms
@maurodandrea maurodandrea self-assigned this Feb 13, 2024
@maurodandrea maurodandrea requested a review from a team as a code owner February 13, 2024 20:16
Copy link

changeset-bot bot commented Feb 13, 2024

⚠️ No Changeset found

Latest commit: 17d45f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

terraform-fmt
@maurodandrea maurodandrea changed the title [DEV-1382] - Create Certificate and DNS zone for CMS Strapi [DEV-1382] - Create Certificate for CMS Strapi Feb 14, 2024
.infrastructure/98_variables.tf Outdated Show resolved Hide resolved
.infrastructure/98_variables.tf Outdated Show resolved Hide resolved
.infrastructure/env/dev/terraform.tfvars Outdated Show resolved Hide resolved
.infrastructure/env/prod/terraform.tfvars Outdated Show resolved Hide resolved
remove-dns-zone-split-pr
Copy link

dpulls bot commented Feb 14, 2024

🎉 All dependencies have been resolved !

Copy link
Contributor

Branch is not up to date with base branch

@maurodandrea it seems this Pull Request is not updated with base branch.
Please proceed with a merge or rebase to solve this.

Copy link
Contributor

@kin0992 kin0992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒

Copy link
Contributor

Jira Pull Request Link

This Pull Request refers to the following Jira issue DEV-1382

Copy link
Contributor

📦 Next.js Bundle Analysis for nextjs-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants