This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
[#174469249] no false positives for connection string syntax #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balanza
changed the title
balanza
suggested changes
Sep 7, 2020
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| # Azure Storage Account Access Key (so far they have this format) | |||
| # alternatively we can grep for endpoint suffixes like core.windows.net | |||
| [A-Za-z0-9+\/]{86}== | |||
| AccountKey=[A-Za-z0-9+\/=]{88}; | |||
There was a problem hiding this comment.
I think this weakens the test a lot. Consider the following environment config:
COSMOSDB_KEY=TEST3bpK0eC/LMP8FtweEFJysEPJZe4sVJX0zQla3ec/MNUFKklsyW3GrTwoJ3EbXnneSzS3ghwz6czDXYqxeU==
COSMOSDB_NAME=dbname
CUSTOMCONNSTR_COSMOSDB_KEY=AccountEndpoint=$COSMOSDB_URI;AccountKey=$COSMOSDB_KEY;The new regex doesn't catch it although this is valid code (actually, that's my own configuration 😬 ).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.