Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SES added to Test Container #1302

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

AWS SES added to Test Container #1302

wants to merge 5 commits into from

Conversation

Viktor-K
Copy link
Collaborator

Description

This PR introduces an AWS SES image in test container test suite, all test in agreement-email-sender are tested against aws-ses-v2-local server (reference here) .

@Viktor-K Viktor-K requested a review from ecamellini December 16, 2024 14:37
ecamellini
ecamellini approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@ecamellini ecamellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 left two very minor comments

packages/commons-test/src/containerTestUtils.ts Outdated Show resolved Hide resolved
packages/commons-test/.env.test Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecamellini ecamellini ecamellini approved these changes

@beetlecrunch beetlecrunch Awaiting requested review from beetlecrunch beetlecrunch is a code owner

@galales galales Awaiting requested review from galales galales is a code owner

@AsterITA AsterITA Awaiting requested review from AsterITA AsterITA is a code owner

@Carminepo2 Carminepo2 Awaiting requested review from Carminepo2 Carminepo2 is a code owner

@taglioni-r taglioni-r Awaiting requested review from taglioni-r taglioni-r is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Viktor-K @ecamellini