Event repository fix edge case #1320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalpenZibo
changed the title
MalpenZibo
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
MalpenZibo
requested review from
Viktor-K,
ecamellini,
sandrotaje and
zerbiniandrea
sandrotaje
approved these changes
Jan 9, 2025
ecamellini
approved these changes
Jan 9, 2025
zerbiniandrea
approved these changes
Jan 13, 2025
AsterITA
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a "bug" that doesn't create any real problem.
When creating multiple events on a new stream ID, the version number sequence used is [0, 0, 1, 2 ... n]. This sequence is correctly saved in the database as [0, 1, 2, 3 ... n].
After this changes to create an event that creates a new stream ID, the first version number should be undefined so the sequence to use will be [undefined, 0, 1, 2 ... n]. Inside the database nothing changes and the sequence is saved as [0, 1, 2, 3 ... n].