PIN-5619 clone purpose #1355
Open
PIN-5619 clone purpose #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrotaje
changed the base branch from
develop
to
PIN-5816_createPurposeDelegation
sandrotaje
force-pushed
the
PIN-5619_clone_purpose
branch
from
8a6ed53 to
2b0bc0b
Compare
sandrotaje
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
zerbiniandrea
approved these changes
Jan 13, 2025
ecamellini
removed request for
beetlecrunch,
galales,
Carminepo2 and
taglioni-r
ecamellini
requested changes
Jan 13, 2025
There was a problem hiding this comment.
I see that this functionality still has unresolved doubts in the requirements: https://pagopa.atlassian.net/wiki/spaces/PDNDI/pages/1236959344/SRS+Incaricato#Clonazione-finalit%C3%A0-in-delega
Were these doubts solved?
| @@ -1180,6 +1193,21 @@ export function purposeServiceBuilder( | |||
|
|
|||
| const purposeToClone = await retrievePurpose(purposeId, readModelService); | |||
|
|
|||
| const activeConsumerDelegation = purposeToClone.data.delegationId | |||
| ? await retrieveDelegation( | |||
There was a problem hiding this comment.
If we decide to remove the delegationId from the purpose model (see Slack thread: https://buildo.slack.com/archives/C07U5M9SJ1Y/p1736783396238289) then here we will need to use one of the other readmodel methods (probably getActiveConsumerDelegationByPurpose) as done in other functions here
Base automatically changed from
PIN-5816_createPurposeDelegation
to
feature/incaricato
January 14, 2025 08:42
sandrotaje
force-pushed
the
PIN-5619_clone_purpose
branch
from
3f5b66f to
5250562
Compare
AsterITA
reviewed
Jan 15, 2025
sandrotaje
force-pushed
the
PIN-5619_clone_purpose
branch
from
aac69c1 to
3995b65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1326
Smoke tested as: