PIN-5849 - restrict agreements visibility only to allowed tenants #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecamellini
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
ecamellini
changed the title
galales
reviewed
Feb 18, 2025
ecamellini
commented
Feb 20, 2025
There was a problem hiding this comment.
@galales @sandrotaje @MalpenZibo I added the permissions check at a readmodel query level also in the other three listings that @galales pointed out, as we discussed, so that only tenants/eservices for allowed agreements are returned
Comment on lines
-856
to
-864
| - in: query | ||
| name: states | ||
| description: comma separated sequence of states | ||
| schema: | ||
| type: array | ||
| items: | ||
| $ref: "#/components/schemas/AgreementState" | ||
| default: [] | ||
| explode: false |
There was a problem hiding this comment.
discussed with the front-end, this param is never used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIN-5849