chore(IT Wallet): [SIW-975,SIW-976] Wallet instance registration and attestation retrieval #5861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 413bb3f.
…T-342-react-native-upgrade
Comment on lines
32
to
35
| await WalletInstance.createWalletInstance({ | ||
| integrityContext, | ||
| walletProviderBaseUrl: itwWalletProviderBaseUrl | ||
| }); |
There was a problem hiding this comment.
We have to pass the appFetch of the app which includes our custom headers, otherwise this won't work in production. Also, we have to manage the LV 401 status code.
There was a problem hiding this comment.
Addressed in 1c430ba
Since we are not in a saga we have to implement custom logic to handle the 401. I think we should address it in a dedicated task.
There was a problem hiding this comment.
I craeated a task at the top of the backlog since this might be a blocking issue. Thanks.
| await generate(ephemeralKey); | ||
| const wiaCryptoContext = createCryptoContextFor(ephemeralKey); | ||
|
|
||
| return WalletInstanceAttestation.getAttestation({ |
There was a problem hiding this comment.
Same as above (line 53).
mastro993
added a commit
that referenced
this pull request
Jul 17, 2024
> [!Warning] > This PR depends on #5861 ## Short description This PR adds a lifecycle reducer to IT Wallet. The goal of this reducer is to persist the wallet instance state (installed, operational, valid, deactivated), so it is available in the global store. ## List of changes proposed in this pull request - Add persisted lifecycle ITW reducer - Update the wallet instance state from the eID issuance machine - Refactor persist logic ## How to test Run the app and check that `features.itWallet.lifecycle` gets updated after the eID issuance. --------- Co-authored-by: Cristiano Tofani <[email protected]> Co-authored-by: Fabio Bombardi <[email protected]> Co-authored-by: LazyAfternoons <[email protected]> Co-authored-by: Federico Mastrini <[email protected]> Co-authored-by: Damiano Plebani <[email protected]> Co-authored-by: Alice Di Rico <[email protected]> Co-authored-by: Mario Perrotta <[email protected]> Co-authored-by: LazyAfternoons <[email protected]> Co-authored-by: Andrea Piai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR depends on #5922
Short description
This PR introduces the wallet instance and attestation retrieval state to the eID issuance machine.
List of changes proposed in this pull request
@pagopa/io-react-native-integritydipendency@pagopa/io-react-native-walletto^0.13.0itwEidIssuanceMachinelogicregisterWalletInstanceandgetWalletAttestationactorsWalletInstanceRegistrationandWalletAttestationRetrievalsubstates toWalletInitializationstateItwIdentificationModeSelectionScreencopyHow to test
In order to test this PR you need a physical device and the io-wallet local development server.
From the IT Wallet playground, go to the Discovery screen. You should be able to go through the wallet init phase and land in the identification screen
Co-authored by: @LazyAfternoons