Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPID-1550] - Download User Data new DS integration #5923

Merged
merged 14 commits into from
Jul 8, 2024

Conversation

ChrisMattew
Copy link
Collaborator

@ChrisMattew ChrisMattew commented Jul 2, 2024

Short description

Revamped Download User Data screen

List of changes proposed in this pull request

  • Integration of the new DS
  • Removal of the alert previously shown after clicking on the CTA

Tests

Tip

Run e2e tests

Screens

Screens: iOS & Android
iOS Android
iOS-profile-download-user-data android-profile-download-user-data
A11Y
iOS Android
iOS-a11y-profile-download-user-data.mov
android-a11y-profile-download-user-data.mp4

How to test

Navigate into Profile -> Privacy Policy and Terms of Service -> Access your data

@ChrisMattew ChrisMattew added the IO-A&I IO - Autenticazione e Identità label Jul 2, 2024
@ChrisMattew ChrisMattew self-assigned this Jul 2, 2024
@ChrisMattew ChrisMattew added the copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label. label Jul 2, 2024
@ChrisMattew
Copy link
Collaborator Author

@mariateresaventura Copy review needed! 🙏🏼

@pagopa-github-bot pagopa-github-bot changed the title [IOPID-1550] - Download User Data new DS integration feat: [IOPID-1550] - Download User Data new DS integration Jul 2, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 2, 2024

Affected stories

  • 🌟 IOPID-1550: [DS-Profile] [APP] Privacy e ToS - Accedi ai tuoi dati
    subtask of

Generated by 🚫 dangerJS against 21e1ad0

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 18 lines in your changes missing coverage. Please review.

Project coverage is 49.36%. Comparing base (4f204b4) to head (21e1ad0).
Report is 252 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5923      +/-   ##
==========================================
+ Coverage   48.42%   49.36%   +0.93%     
==========================================
  Files        1488     1706     +218     
  Lines       31617    33912    +2295     
  Branches     7669     8164     +495     
==========================================
+ Hits        15311    16740    +1429     
- Misses      16238    17108     +870     
+ Partials       68       64       -4     
Files Coverage Δ
ts/components/BulletList.tsx 71.42% <60.00%> (ø)
ts/screens/profile/DownloadProfileDataScreen.tsx 3.33% <0.00%> (-0.52%) ⬇️

... and 879 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a24e6...21e1ad0. Read the comment docs.

@ChrisMattew ChrisMattew requested a review from a team as a code owner July 3, 2024 09:50
Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariateresaventura mariateresaventura removed the copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label. label Jul 8, 2024
@mariateresaventura
Copy link
Contributor

@mariateresaventura Copy review needed! 🙏🏼

Done!

@shadowsheep1 shadowsheep1 merged commit 69c798e into master Jul 8, 2024
13 checks passed
@shadowsheep1 shadowsheep1 deleted the IOPID-1550-user-data branch July 8, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants