-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-1313] Add IT Wallet trial system status #5932
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5932 +/- ##
==========================================
+ Coverage 48.42% 49.00% +0.57%
==========================================
Files 1488 1716 +228
Lines 31617 34319 +2702
Branches 7669 8448 +779
==========================================
+ Hits 15311 16817 +1506
- Misses 16238 17437 +1199
+ Partials 68 65 -3
... and 1014 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
🎉 All dependencies have been resolved ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,3 @@ | |||
import { TrialId } from "../../../../../definitions/trial_system/TrialId"; | |||
|
|||
export const ITW_TRIAL_ID = "01J2GN4TA8FB6DPTAX3T3YD6M1" as TrialId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use our env file for this ID? Does it make sense to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using env makes sense when you have different values for different environments. In this case I don't see any reason to have different IDs. I mean, we are free to use it in our local development server. Does this makes sense to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue that we are using the .env
also for constants as there are a few entries which have the same value in both local and production. Up to you anyway, it was just a general comment on the matter as I'd rather have a place where all the consts are stored rather than a specialised file which probably will only contain a single const. We can leave as it is
One is a generic playground, introduced by this PR #5794, the other is specific for IT Wallet and uses the correct trial ID. |
This reverts commit 93affab.
Short description
This PR allows the app to know if the user is enabled to use the IT Wallet experimental features
List of changes proposed in this pull request
trial_system
typo in type definitions scriptHow to test
With the
io-dev-api-server
, go to Profile > Playgrounds > IT Wallet > Trial. You should be able to enable, refresh and reset the IT Wallet trial system.Preview
RocketSim_Recording_iPhone_14_6.1_2024-07-05_10.06.08.mp4