Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-1313] Add IT Wallet trial system status #5932

Merged
merged 16 commits into from
Jul 15, 2024

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Jul 4, 2024

Short description

This PR allows the app to know if the user is enabled to use the IT Wallet experimental features

List of changes proposed in this pull request

  • Fixed trial_system typo in type definitions script
  • Added IT Wallet trial system status read at app boot
  • Added IT Wallet trial system playgrounds

How to test

With the io-dev-api-server, go to Profile > Playgrounds > IT Wallet > Trial. You should be able to enable, refresh and reset the IT Wallet trial system.

Preview

RocketSim_Recording_iPhone_14_6.1_2024-07-05_10.06.08.mp4

@pagopa-github-bot pagopa-github-bot changed the title [SIW-1313] Add IT Wallet trial system status chore(IT Wallet): [SIW-1313] Add IT Wallet trial system status Jul 4, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 4, 2024

Affected stories

  • ⚙️ SIW-1313: Implementazione lettura stato sperimentazione F&F
    subtask of
    • 🌟 SIW-1194: [app] come wallet provider voglio conoscere quali sono gli utenti abilitati alla sperimentazione F&F

Generated by 🚫 dangerJS against 52a93d4

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 49.00%. Comparing base (4f204b4) to head (52a93d4).
Report is 269 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5932      +/-   ##
==========================================
+ Coverage   48.42%   49.00%   +0.57%     
==========================================
  Files        1488     1716     +228     
  Lines       31617    34319    +2702     
  Branches     7669     8448     +779     
==========================================
+ Hits        15311    16817    +1506     
- Misses      16238    17437    +1199     
+ Partials       68       65       -3     
Files Coverage Δ
ts/features/itwallet/common/utils/itwTrialUtils.ts 100.00% <100.00%> (ø)
...res/itwallet/playgrounds/screens/ItwPlayground.tsx 11.76% <ø> (ø)
ts/features/trialSystem/api/client.ts 25.00% <ø> (ø)
ts/features/trialSystem/store/actions/index.ts 100.00% <ø> (ø)
ts/features/trialSystem/store/reducers/index.ts 29.26% <ø> (ø)
ts/screens/profile/TrialSystemPlayground.tsx 15.78% <ø> (ø)
ts/features/itwallet/common/saga/index.ts 0.00% <0.00%> (ø)
...t/playgrounds/components/ItwTrialSystemSection.tsx 5.88% <5.88%> (ø)

... and 1014 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7a0b1...52a93d4. Read the comment docs.

Copy link

dpulls bot commented Jul 5, 2024

🎉 All dependencies have been resolved !

@mastro993 mastro993 marked this pull request as ready for review July 11, 2024 13:09
@mastro993 mastro993 requested a review from a team as a code owner July 11, 2024 13:09
Copy link
Contributor

@hevelius hevelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS simulator. What is the difference between IT Wallet -> Trial ... and Partecipa alla sperimentazione in the playground section?
Simulator Screenshot - iPhone 15 Pro - 2024-07-12 at 12 12 49
Simulator Screenshot - iPhone 15 Pro - 2024-07-12 at 12 11 59

@@ -0,0 +1,3 @@
import { TrialId } from "../../../../../definitions/trial_system/TrialId";

export const ITW_TRIAL_ID = "01J2GN4TA8FB6DPTAX3T3YD6M1" as TrialId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use our env file for this ID? Does it make sense to you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using env makes sense when you have different values for different environments. In this case I don't see any reason to have different IDs. I mean, we are free to use it in our local development server. Does this makes sense to you?

Copy link
Contributor

@LazyAfternoons LazyAfternoons Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that we are using the .env also for constants as there are a few entries which have the same value in both local and production. Up to you anyway, it was just a general comment on the matter as I'd rather have a place where all the consts are stored rather than a specialised file which probably will only contain a single const. We can leave as it is

@mastro993
Copy link
Contributor Author

Tested on iOS simulator. What is the difference between IT Wallet -> Trial ... and Partecipa alla sperimentazione in the playground section? Simulator Screenshot - iPhone 15 Pro - 2024-07-12 at 12 12 49 Simulator Screenshot - iPhone 15 Pro - 2024-07-12 at 12 11 59

One is a generic playground, introduced by this PR #5794, the other is specific for IT Wallet and uses the correct trial ID.

@mastro993 mastro993 merged commit ba90570 into master Jul 15, 2024
13 checks passed
@mastro993 mastro993 deleted the SIW-1313-add-itw-feature-trial-status branch July 15, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants