Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Sort onboarded payment methods by creation date #5938

Merged
merged 15 commits into from
Jul 25, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Jul 8, 2024

Short description

This PR sorts a user's onboarded payment methods by creation date descending

List of changes proposed in this pull request

  • Added a orderBy loadash helper to order by creationDate descending while creating the selector paymentsWalletUserMethodsSelector

How to test

When you onboard a new payment method, you should be able to see the latest onboarded payment method as first element in the carousel from the Payment home screen.

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 8, 2024

Warnings
⚠️ Please include a Jira ticket at the beginning of the PR title

Example of PR titles that include Jira tickets:

  • single story: [PROJID-123] my PR title
  • multiple stories: [PROJID-1,PROJID-2,PROJID-3] my PR title

Generated by 🚫 dangerJS against dd93f7e

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.74%. Comparing base (4f204b4) to head (51be960).
Report is 331 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5938      +/-   ##
==========================================
+ Coverage   48.42%   48.74%   +0.31%     
==========================================
  Files        1488     1756     +268     
  Lines       31617    35440    +3823     
  Branches     7669     8570     +901     
==========================================
+ Hits        15311    17275    +1964     
- Misses      16238    18098    +1860     
+ Partials       68       67       -1     
Files Coverage Δ
.../features/payments/wallet/store/selectors/index.ts 75.00% <50.00%> (-25.00%) ⬇️

... and 1105 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8077783...51be960. Read the comment docs.

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hantex9 Hantex9 merged commit cbc0468 into master Jul 25, 2024
11 checks passed
@Hantex9 Hantex9 deleted the IOBP-736-order-wallet-carousel branch July 25, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants