chore: [IOPLT-603] Sets Android API Level 34 #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit db0583d.
This reverts commit 81530b8.
This reverts commit 7d1beca.
Co-authored-by: Cristiano Tofani <[email protected]>
shadowsheep1
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
LGTM, tested:
- Build from scratch.
- EIC Login.
- Camera Permissions on both Android 14 and 12.
We need just to remember that for the future:
[VisionCamera] react-native-worklets-core not found, Frame Processors disabled!
WARNING:We recommend using a newer Android Gradle plugin to use compileSdk = 34
This Android Gradle plugin (7.4.2) was tested up to compileSdk = 33
This warning can be suppressed by adding
android.suppressUnsupportedCompileSdk=34
to this project's gradle.properties
The build will continue, but you are strongly encouraged to update your project to
use a newer Android Gradle Plugin that has been tested with compileSdk = 34
LazyAfternoons
approved these changes
Jul 22, 2024
dmnplb
added a commit
that referenced
this pull request
Aug 8, 2024
… + Dynamic header background (under the new Experimental Lab category) (#5954) > [!note] > This PR depends on: > * #5947 ## Short description This PR adds the latest version of the `react-native-skia` library and the new **Experimental Lab** section which includes the new **Dynamic header background** screen, built with the `skia` library ## List of changes proposed in this pull request - Add the `react-native-skia` library - Update `jest` config files to include `react-native-skia` references - Add the new **Experimental Lab** section - Add the new **Dynamic header background** as first experiment ### Preview https://github.com/pagopa/io-app/assets/1255491/802fee95-72ac-46d1-9a93-cdf8e5195b88 ### Acknowledgement We've successfully added this library thanks to the RN upgrade to the `0.72` version: - #5864 ## How to test 1. Launch the app in the local environment 2. Go to the **Experimental Lab** → **Dynamic header background** --------- Co-authored-by: LazyAfternoons <[email protected]> Co-authored-by: Cristiano Tofani <[email protected]> Co-authored-by: Federico Mastrini <[email protected]> Co-authored-by: Mario Perrotta <[email protected]> Co-authored-by: Fabio Bombardi <[email protected]> Co-authored-by: Alice Di Rico <[email protected]> Co-authored-by: LazyAfternoons <[email protected]> Co-authored-by: Andrea Piai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Depends on #5864
Short description
This PR sets Android API Level to 34 and upgrades
react-native-vision-camerato solve compatibility issuesList of changes proposed in this pull request
vision-camera-code-scannerreact-native-vision-cameraHow to test
Test barcode code scanning to check everything is ok on both iOS and Android. Normally use the App on Android to check if the new API Level bump compromises anything