Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOBP-723,IOBP-772] Add mixpanel profile properties for the new payment flow #5950

Merged
merged 16 commits into from
Jul 24, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Jul 10, 2024

Short description

This PR adds mixpanel profile properties about the user successful payments counter and saved payment methods count.

List of changes proposed in this pull request

  • Added profile properties configuration about the payments environment;
  • Created the getPaymentsAnalyticsConfiguration that gets the payments-domain related properties used in the tracking strategy.
  • Fixed some of the properties that were not propagated to mixpanel events

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 10, 2024

Warnings
⚠️

Multiple stories with different types are associated with this Pull request.
Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • ⚙️ IOBP-723: Aggiungere il tracciamento per le Profile Properties nei pagamenti
    subtask of
    • 🌟 IOBP-772: Pagamento in IO - Refinement eventi
  • 🌟 IOBP-772: Pagamento in IO - Refinement eventi
    subtask of
    • IOBP-769: Pagamento in IO - Tracking implementation

Generated by 🚫 dangerJS against 2c7f518

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 10.71429% with 25 lines in your changes missing coverage. Please review.

Project coverage is 49.03%. Comparing base (4f204b4) to head (2c7f518).
Report is 320 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5950      +/-   ##
==========================================
+ Coverage   48.42%   49.03%   +0.60%     
==========================================
  Files        1488     1748     +260     
  Lines       31617    35122    +3505     
  Branches     7669     8628     +959     
==========================================
+ Hits        15311    17221    +1910     
- Misses      16238    17826    +1588     
- Partials       68       75       +7     
Files Coverage Δ
.../features/payments/history/store/reducers/index.ts 43.75% <ø> (-12.25%) ⬇️
...ts/checkout/screens/WalletPaymentConfirmScreen.tsx 5.31% <0.00%> (-5.40%) ⬇️
...ts/checkout/screens/WalletPaymentPickPspScreen.tsx 3.27% <0.00%> (-0.50%) ⬇️
.../features/payments/wallet/store/selectors/index.ts 85.71% <50.00%> (-14.29%) ⬇️
ts/mixpanelConfig/profileProperties.ts 26.92% <0.00%> (-3.52%) ⬇️
.../features/payments/common/store/selectors/index.ts 44.44% <25.00%> (ø)
...ts/checkout/screens/WalletPaymentOutcomeScreen.tsx 0.95% <0.00%> (-0.62%) ⬇️
ts/features/payments/checkout/analytics/index.ts 23.14% <14.28%> (ø)
...nts/checkout/screens/WalletPaymentDetailScreen.tsx 6.89% <0.00%> (-2.20%) ⬇️

... and 1086 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287555a...2c7f518. Read the comment docs.

@Hantex9 Hantex9 changed the title chore: [IOBP-723] Add mixpanel profile properties for the new payment flow chore: [IOBP-723,IOBP-772] Add mixpanel profile properties for the new payment flow Jul 17, 2024
@pagopa-github-bot pagopa-github-bot changed the title chore: [IOBP-723,IOBP-772] Add mixpanel profile properties for the new payment flow feat: [IOBP-723,IOBP-772] Add mixpanel profile properties for the new payment flow Jul 17, 2024
@Hantex9 Hantex9 merged commit 2b5adad into master Jul 24, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-723-payment-flow-profile-properties branch July 24, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants