Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOCOM-1338, IOCOM-1562, IOCOM-1563] FIMS history export feature #6091

Merged

Conversation

forrest57
Copy link
Contributor

@forrest57 forrest57 commented Aug 5, 2024

Short description

Addition of Fims history export feature

Screen.Recording.2024-08-06.at.15.27.27.mov

List of changes proposed in this pull request

  • history export saga
  • error/confirm alerts
  • required i18n entries
  • system alerts for both export request confirmation and already exporting notification

How to test

using the dev-server, navigate to profile>privacy>third party accesses and play around with the export functionality.
Make sure everything works as expected.

@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-1338] FIMS history export feature feat: [IOCOM-1338] FIMS history export feature Aug 5, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Aug 5, 2024

Warnings
⚠️ Please include a Jira ticket at the beginning of the PR title

Example of PR titles that include Jira tickets:

  • single story: [PROJID-123] my PR title
  • multiple stories: [PROJID-1,PROJID-2,PROJID-3] my PR title

Generated by 🚫 dangerJS against 6319aa0

@Vangaorth Vangaorth changed the title feat: [IOCOM-1338] FIMS history export feature [IOCOM-1338, IOCOM-1562, IOCOM-1563] FIMS history export feature Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 10.81081% with 66 lines in your changes missing coverage. Please review.

Project coverage is 47.69%. Comparing base (4f204b4) to head (6319aa0).
Report is 406 commits behind head on master.

Files Patch % Lines
.../fims/history/hooks/useFimsHistoryResultToasts.tsx 12.90% 27 Missing ⚠️
...s/fims/history/saga/handleExportFimsHistorySaga.ts 0.00% 16 Missing ⚠️
ts/features/fims/history/screens/HistoryScreen.tsx 0.00% 12 Missing ⚠️
ts/features/fims/history/store/reducer/index.ts 0.00% 8 Missing ⚠️
ts/features/fims/history/store/selectors/index.ts 50.00% 2 Missing ⚠️
ts/features/fims/history/saga/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6091      +/-   ##
==========================================
- Coverage   48.42%   47.69%   -0.74%     
==========================================
  Files        1488     1716     +228     
  Lines       31617    34475    +2858     
  Branches     7669     8280     +611     
==========================================
+ Hits        15311    16443    +1132     
- Misses      16238    17971    +1733     
+ Partials       68       61       -7     
Files Coverage Δ
ts/features/fims/history/store/actions/index.ts 100.00% <100.00%> (ø)
ts/features/fims/history/saga/index.ts 0.00% <0.00%> (ø)
ts/features/fims/history/store/selectors/index.ts 57.14% <50.00%> (ø)
ts/features/fims/history/store/reducer/index.ts 26.08% <0.00%> (ø)
ts/features/fims/history/screens/HistoryScreen.tsx 3.84% <0.00%> (ø)
...s/fims/history/saga/handleExportFimsHistorySaga.ts 0.00% <0.00%> (ø)
.../fims/history/hooks/useFimsHistoryResultToasts.tsx 12.90% <12.90%> (ø)

... and 1157 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3665c93...6319aa0. Read the comment docs.

@forrest57 forrest57 marked this pull request as ready for review August 6, 2024 13:41
@forrest57 forrest57 requested review from thisisjp and a team as code owners August 6, 2024 13:41
Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forrest57 forrest57 merged commit b0f8a2e into master Aug 9, 2024
13 checks passed
@forrest57 forrest57 deleted the IOCOM-1562-app-sviluppo-saga-per-export-fims-history branch August 9, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants