Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [IOBP-828] Receipts Micro-copy improvements #6100

Merged
merged 5 commits into from
Aug 28, 2024
Merged

chore: [IOBP-828] Receipts Micro-copy improvements #6100

merged 5 commits into from
Aug 28, 2024

Conversation

thisisjp
Copy link
Contributor

@thisisjp thisisjp commented Aug 8, 2024

  • replaced PagoPA with pagoPA
  • changed verb in the CTA to download receipt
  • edited the failure feedback

@thisisjp
Micro-copy improvements
a53a5a6 
- replaced PagoPA with pagoPA
- changed verb in the CTA to download receipt
- edited the failure feedback
@thisisjp thisisjp added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Aug 8, 2024
@thisisjp thisisjp requested a review from a team as a code owner August 8, 2024 08:48
@pagopa-github-bot pagopa-github-bot changed the title [IOBP-828] Receipts Micro-copy improvements chore: [IOBP-828] Receipts Micro-copy improvements Aug 8, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Aug 8, 2024 •
edited by jira bot
Loading

Affected stories

  • ⚙️ IOBP-828: Modificare CTA per ottenere ricevuta PDF
    subtask of
    • ⚡ IOBP-540: Integrazione IO-BIZ Event/ricevute

Generated by 🚫 dangerJS against dc21e4c

@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.68%. Comparing base (4f204b4) to head (dc21e4c).
Report is 420 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6100      +/-   ##
==========================================
- Coverage   48.42%   47.68%   -0.75%     
==========================================
  Files        1488     1720     +232     
  Lines       31617    34756    +3139     
  Branches     7669     8362     +693     
==========================================
+ Hits        15311    16573    +1262     
- Misses      16238    18122    +1884     
+ Partials       68       61       -7

see 1178 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e05999...dc21e4c. Read the comment docs.

@thisisjp thisisjp requested a review from Hantex9 August 28, 2024 10:16
Hantex9
Hantex9 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hantex9 Hantex9 merged commit 31080d9 into master Aug 28, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-828 branch August 28, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hantex9 Hantex9 Hantex9 approved these changes

Assignees

@Hantex9 Hantex9

Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisisjp @pagopa-github-bot @Hantex9