-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IT Wallet): [SIW-1972] Remote presentation same device #6689
Open
RiccardoMolinari95
wants to merge
32
commits into
master
Choose a base branch
from
SIW-1972-remote-presentation-same-device
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(IT Wallet): [SIW-1972] Remote presentation same device #6689
RiccardoMolinari95
wants to merge
32
commits into
master
from
SIW-1972-remote-presentation-same-device
+265
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR introduces the ability to start the remote presentation flow through a deep link in a same-device scenario.
List of changes proposed in this pull request
useItwLinkingOptions
to include linking options for remote deep linkItwRemoteRequestValidationScreen
, which receives thepayload
and validates it. If thepayload
is invalid, an error screen, for deeplink, will be displayed (TODO). If valid, it sends thestart
event to the remote presentation machinedecodeItwRemoteBarcode
to validate that the URL starts with https://continua.io.pagopa.it/itw/auth, checks the content of the QR code against theItwRemoteRequestPayload
type, and finally sends the URLHow to test
Use the following link as a deep link and to generate a QR code:
https://continua.io.pagopa.it/itw/auth?client_id=abc123xy&request_uri=https%3A%2F%2Fexample.com%2Fcallback&state=hyqizm592