chore(IT Wallet): [SIW-1964] Add failure screen for missing credentials in presentation #6702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing-credential-screen
gispada
requested review from
thisisjp,
ChrisMattew,
freddi301 and
a team
as code owners
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6702 +/- ##
==========================================
- Coverage 50.01% 50.00% -0.02%
==========================================
Files 1557 1557
Lines 32438 32445 +7
Branches 7345 7295 -50
==========================================
Hits 16223 16223
- Misses 16163 16183 +20
+ Partials 52 39 -13
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Base automatically changed from
SIW-1962-remote-presentation-check-wi
to
master
February 12, 2025 12:24
|
🎉 All dependencies have been resolved ! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
…ls in presentation (#6702) > [!WARNING] > Depends on #6694 ## Short description This PR adds a failure screen for missing credentials in the remote presentation flow. Note that since the presentation flow is still a work in progress, the screen is not fully implemented. ## List of changes proposed in this pull request - Improved typing of failure reasons - Added a case for missing credentials ## How to test Currently the only way to test the screen is to mock it, forcing the `MISSING_CREDENTIALS` failure. --------- Co-authored-by: RiccardoMolinari95 <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Depends on #6694
Short description
This PR adds a failure screen for missing credentials in the remote presentation flow. Note that since the presentation flow is still a work in progress, the screen is not fully implemented.
List of changes proposed in this pull request
How to test
Currently the only way to test the screen is to mock it, forcing the
MISSING_CREDENTIALSfailure.