Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:[#IOPID-105] Add Opex dashboard #951

Open
wants to merge 73 commits into
base: master
Choose a base branch
from
Open

feat:[#IOPID-105] Add Opex dashboard #951

wants to merge 73 commits into from

Conversation

pasqualedevita
Copy link
Member

@pasqualedevita pasqualedevita commented Dec 21, 2022 •
edited
Loading

List of Changes

Add opex dashboards for:

  • api_auth
  • api_backend
  • api_cgn

Motivation and Context

PagoPA Operational Excellence standards.
More info at:

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

@pasqualedevita pasqualedevita marked this pull request as ready for review December 21, 2022 12:57
@pasqualedevita pasqualedevita requested a review from a team as a code owner December 21, 2022 12:57
gunzip
gunzip reviewed Dec 22, 2022
View reviewed changes
.identity/02_application_master.tf
@@ -0,0 +1,28 @@
resource "azuread_application" "master" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to encapsulate all these files into a terraform module in order to leave here only the parameters that have to be configured? (ie. the branch name and so on)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can, but I want to think about it... It's not complex or verbose configuration

gquadrati
gquadrati reviewed Jan 11, 2023
View reviewed changes
.opex/api_cgn/env/prod/config.yaml Outdated Show resolved Hide resolved
.opex/api_backend/env/prod/config.yaml Outdated Show resolved Hide resolved
gquadrati
gquadrati requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to move back ASAP

.opex/api_auth/env/prod/config.yaml Outdated Show resolved Hide resolved
.opex/api_backend/env/prod/config.yaml Outdated Show resolved Hide resolved
.opex/api_cgn/env/prod/config.yaml Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 25, 2023 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-105

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gquadrati gquadrati changed the title feat: Add Opex dashboard feat:[#IOPID-105] Add Opex dashboard Apr 6, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pasqualedevita and others added 27 commits July 20, 2023 13:18
@gquadrati
try change
b17e8ee
@gquadrati
contr
09aabb6
@gquadrati
rollback
8d3ac4c
@gquadrati
fix dashboard id and name
021ab3c
@gquadrati
Apply suggestions from code review
236788b
@gquadrati
Update .opex/api_eucovidcert/env/prod/config.yaml
c065fe1
@gquadrati
override eucovidcert endpoint threshold
4cf48bb
@gquadrati
wip
75fe3e5
@gquadrati
wip
17dba4d
@gquadrati
fix api_public openapi
fe44c3b
@gquadrati
add acs endpoint to api_public openapi
a950126
@gquadrati
move to iopquarantineerror + add ovrride
65e97f8
@gquadrati
move threshold to 3s for acs endpoint
0f2a452
@gquadrati
upgrade opex-dashboard
652f8d3
@gquadrati
upgrade opex-dashboard
5eb2838
@gquadrati
fix api_bpd openapi
4de2855
@gquadrati
fix api_fims openapi
d5f27eb
@gquadrati
fix api_mit_voucher openapi
66f128a
@gquadrati
fix api_pagopa openapi
9c36fa7
@gquadrati
fix api_parameters openapi
3e83d5d
@gquadrati
move to new action groups, set evaluation parameters
c892b54
@gquadrati
override defaults for payment APIs
cbf8e11
@gquadrati
tune api_public alerts
53971db
@gquadrati
fix
f08909a
@gquadrati
tune all api_public endpoints
12795f9
@gquadrati
wip
af14370
@gquadrati
update opex-dashboard version
a259683
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gquadrati gquadrati gquadrati requested changes

@gunzip gunzip gunzip left review comments

@fabriziopapi fabriziopapi Awaiting requested review from fabriziopapi fabriziopapi is a code owner automatically assigned from pagopa/io-backend-contributors

@StefanoDoc StefanoDoc Awaiting requested review from StefanoDoc StefanoDoc is a code owner automatically assigned from pagopa/io-backend-contributors

@arcogabbo arcogabbo Awaiting requested review from arcogabbo

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pasqualedevita @pagopa-github-bot @gunzip @arcogabbo @gquadrati