-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New audit log implementation #64
Conversation
📖 Terraform Plan ('infra/resources/prod') - successTerraform PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# module.web_apps.module.op_func.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
~ app_settings = {
~ "FIMS_STORAGE__queueServiceUri" = "https://iopfimsst.queue.core.windows.net" -> "https://iopfimsst.queue.core.windows.net/"
# (15 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-weu-fims-rg-01/providers/Microsoft.Web/sites/io-p-weu-fims-op-func-01"
name = "io-p-weu-fims-op-func-01"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO Comunicazione"
"Source" = "https://github.com/pagopa/io-fims/blob/main/infra/prod/westeurope"
"hidden-link: /app-insights-conn-string" = "InstrumentationKey=ab45103a-cb4f-474b-933f-d802ed1082d5;IngestionEndpoint=https://westeurope-3.in.applicationinsights.azure.com/;LiveEndpoint=https://westeurope.livediagnostics.monitor.azure.com/;ApplicationId=2a5ffa17-99f9-4d9b-a253-18dba6759d94"
"hidden-link: /app-insights-instrumentation-key" = "ab45103a-cb4f-474b-933f-d802ed1082d5"
"hidden-link: /app-insights-resource-id" = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/microsoft.insights/components/io-p-ai-common"
}
# (26 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# module.web_apps_itn.module.user_func.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
~ app_settings = {
~ "WEBSITE_WARMUP_PATH" = "/api/health" -> "/api/v1/fims/health"
# (16 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-fims-rg-01/providers/Microsoft.Web/sites/io-p-itn-fims-user-func-01"
name = "io-p-itn-fims-user-func-01"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO Comunicazione"
"Source" = "https://github.com/pagopa/io-fims/blob/main/infra/prod/westeurope"
"hidden-link: /app-insights-conn-string" = "InstrumentationKey=ab45103a-cb4f-474b-933f-d802ed1082d5;IngestionEndpoint=https://westeurope-3.in.applicationinsights.azure.com/;LiveEndpoint=https://westeurope.livediagnostics.monitor.azure.com/;ApplicationId=2a5ffa17-99f9-4d9b-a253-18dba6759d94"
"hidden-link: /app-insights-instrumentation-key" = "ab45103a-cb4f-474b-933f-d802ed1082d5"
"hidden-link: /app-insights-resource-id" = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/microsoft.insights/components/io-p-ai-common"
}
# (26 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# module.web_apps_itn.module.user_func.azurerm_linux_function_app_slot.this[0] will be updated in-place
~ resource "azurerm_linux_function_app_slot" "this" {
~ app_settings = {
~ "WEBSITE_WARMUP_PATH" = "/api/health" -> "/api/v1/fims/health"
# (16 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-fims-rg-01/providers/Microsoft.Web/sites/io-p-itn-fims-user-func-01/slots/staging"
name = "staging"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "IO Comunicazione"
"Source" = "https://github.com/pagopa/io-fims/blob/main/infra/prod/westeurope"
}
# (22 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
Plan: 0 to add, 3 to change, 0 to destroy.
Warning: Argument is deprecated
with module.cosmos.module.comsosdb_sql_container_op_access_tokens.azurerm_cosmosdb_sql_container.this,
on .terraform/modules/cosmos.comsosdb_sql_container_op_access_tokens/cosmosdb_sql_container/main.tf line 7, in resource "azurerm_cosmosdb_sql_container" "this":
7: partition_key_path = var.partition_key_path
`partition_key_path` will be removed in favour of the property
`partition_key_paths` in version 4.0 of the AzureRM Provider.
(and 14 more similar warnings elsewhere)
Warning: Deprecated attribute
on .terraform/modules/cosmos.cosmosdb_account_fims/cosmosdb_account/output.tf line 54, in output "connection_strings":
54: value = azurerm_cosmosdb_account.this.connection_strings
The attribute "connection_strings" is deprecated. Refer to the provider
documentation for details.
(and one more similar warning elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
- Coverage 54.83% 46.47% -8.36%
==========================================
Files 109 127 +18
Lines 6002 5622 -380
Branches 369 229 -140
==========================================
- Hits 3291 2613 -678
- Misses 2661 2943 +282
- Partials 50 66 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that we don't have an env.example
do we plan to add it so we can list the env variables needed?
4bb04e3
to
d022802
Compare
093c805
to
975f93c
Compare
c143600
to
a752fae
Compare
List of changes
Motivation and context
This pr adds the implementation to manage the event register required for legal reason as described in the FIMS DR
Type of changes
Env to apply
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)