Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op): implicit consent for internal rp #86

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

lucacavallaro
Copy link
Member

@lucacavallaro lucacavallaro commented Dec 9, 2024

List of changes

  1. Add a new, optional metadata for Client called is_internal (Boolean). Setting is_internal to true means that the external web services referenced by the client metadata (via redirect_uri) is managed by PagoPA S.p.A.
  2. Authentication Requests originated by internal clients no longer require explicit consent by the citizen.

Motivation and context

Internal client does not need an explicit consent by the citizen cause the data will not be shared with third parties.

@lucacavallaro lucacavallaro force-pushed the IOCOM-2019-implicit-consent branch from 57e16db to d4ab326 Compare December 11, 2024 15:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.81%. Comparing base (b8928bb) to head (6a9989c).

Files with missing lines Patch % Lines
...kages/io-fims-common/src/domain/client-metadata.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   46.47%   46.81%   +0.33%     
==========================================
  Files         127      127              
  Lines        5637     5676      +39     
  Branches      229      232       +3     
==========================================
+ Hits         2620     2657      +37     
- Misses       2951     2953       +2     
  Partials       66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacavallaro lucacavallaro force-pushed the IOCOM-2019-implicit-consent branch 2 times, most recently from 5c276de to 5cef04f Compare December 11, 2024 15:57
@lucacavallaro lucacavallaro force-pushed the IOCOM-2019-implicit-consent branch from 5cef04f to 6a9989c Compare December 11, 2024 16:13
@lucacavallaro lucacavallaro marked this pull request as ready for review December 11, 2024 16:14
@lucacavallaro lucacavallaro requested a review from a team as a code owner December 11, 2024 16:14
@lucacavallaro lucacavallaro merged commit fd9f25e into main Dec 11, 2024
7 checks passed
@lucacavallaro lucacavallaro deleted the IOCOM-2019-implicit-consent branch December 11, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants