[CES-584] Give access to common IO KeyVaults to new AD groups #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📖 Terraform Plan ('src/core/prod') - successTerraform PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_adgroup_auth_admins will be created
+ resource "azurerm_key_vault_access_policy" "kv_adgroup_auth_admins" {
+ certificate_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ id = (known after apply)
+ key_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
]
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-sec-rg/providers/Microsoft.KeyVault/vaults/io-p-kv"
+ object_id = "0bd8a47e-3188-45c9-9c74-23f22fca2497"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_adgroup_auth_devs will be created
+ resource "azurerm_key_vault_access_policy" "kv_adgroup_auth_devs" {
+ certificate_permissions = []
+ id = (known after apply)
+ key_permissions = []
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-sec-rg/providers/Microsoft.KeyVault/vaults/io-p-kv"
+ object_id = "0bd8a47e-3188-45c9-9c74-23f22fca2497"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_adgroup_bonus_admins will be created
+ resource "azurerm_key_vault_access_policy" "kv_adgroup_bonus_admins" {
+ certificate_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ id = (known after apply)
+ key_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
]
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-sec-rg/providers/Microsoft.KeyVault/vaults/io-p-kv"
+ object_id = "831e5214-2f68-4a13-b25f-7bec962c7e1b"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_adgroup_bonus_devs will be created
+ resource "azurerm_key_vault_access_policy" "kv_adgroup_bonus_devs" {
+ certificate_permissions = []
+ id = (known after apply)
+ key_permissions = []
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-sec-rg/providers/Microsoft.KeyVault/vaults/io-p-kv"
+ object_id = "861e7fd4-6463-4f69-b473-1e6aaaa4520e"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_adgroup_com_admins will be created
+ resource "azurerm_key_vault_access_policy" "kv_adgroup_com_admins" {
+ certificate_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ id = (known after apply)
+ key_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
]
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-sec-rg/providers/Microsoft.KeyVault/vaults/io-p-kv"
+ object_id = "12a48460-7d95-4d91-ab0a-1d19008aac2c"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_adgroup_com_devs will be created
+ resource "azurerm_key_vault_access_policy" "kv_adgroup_com_devs" {
+ certificate_permissions = []
+ id = (known after apply)
+ key_permissions = []
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-sec-rg/providers/Microsoft.KeyVault/vaults/io-p-kv"
+ object_id = "7b78851b-c40d-497d-ae7f-596b8f92ecf2"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_adgroup_svc_admins will be created
+ resource "azurerm_key_vault_access_policy" "kv_adgroup_svc_admins" {
+ certificate_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ id = (known after apply)
+ key_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
]
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-sec-rg/providers/Microsoft.KeyVault/vaults/io-p-kv"
+ object_id = "100cb2bb-92d5-40ad-bfa9-1d3c676f13e1"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_adgroup_svc_devs will be created
+ resource "azurerm_key_vault_access_policy" "kv_adgroup_svc_devs" {
+ certificate_permissions = []
+ id = (known after apply)
+ key_permissions = []
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-sec-rg/providers/Microsoft.KeyVault/vaults/io-p-kv"
+ object_id = "300ea154-9984-4712-85e9-3abcb3e42960"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_adgroup_wallet_admins will be created
+ resource "azurerm_key_vault_access_policy" "kv_adgroup_wallet_admins" {
+ certificate_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ id = (known after apply)
+ key_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
]
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-sec-rg/providers/Microsoft.KeyVault/vaults/io-p-kv"
+ object_id = "d38daf6e-4e65-46d2-a11a-6e016b29fcbc"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_adgroup_wallet_devs will be created
+ resource "azurerm_key_vault_access_policy" "kv_adgroup_wallet_devs" {
+ certificate_permissions = []
+ id = (known after apply)
+ key_permissions = []
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-sec-rg/providers/Microsoft.KeyVault/vaults/io-p-kv"
+ object_id = "b2ca23d9-ace5-416d-8132-01d9b002db12"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_common_adgroup_auth_admins will be created
+ resource "azurerm_key_vault_access_policy" "kv_common_adgroup_auth_admins" {
+ certificate_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ id = (known after apply)
+ key_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
]
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.KeyVault/vaults/io-p-kv-common"
+ object_id = "0bd8a47e-3188-45c9-9c74-23f22fca2497"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_common_adgroup_auth_devs will be created
+ resource "azurerm_key_vault_access_policy" "kv_common_adgroup_auth_devs" {
+ certificate_permissions = []
+ id = (known after apply)
+ key_permissions = []
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.KeyVault/vaults/io-p-kv-common"
+ object_id = "0bd8a47e-3188-45c9-9c74-23f22fca2497"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_common_adgroup_bonus_admins will be created
+ resource "azurerm_key_vault_access_policy" "kv_common_adgroup_bonus_admins" {
+ certificate_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ id = (known after apply)
+ key_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
]
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.KeyVault/vaults/io-p-kv-common"
+ object_id = "831e5214-2f68-4a13-b25f-7bec962c7e1b"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_common_adgroup_bonus_devs will be created
+ resource "azurerm_key_vault_access_policy" "kv_common_adgroup_bonus_devs" {
+ certificate_permissions = []
+ id = (known after apply)
+ key_permissions = []
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.KeyVault/vaults/io-p-kv-common"
+ object_id = "861e7fd4-6463-4f69-b473-1e6aaaa4520e"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_common_adgroup_com_admins will be created
+ resource "azurerm_key_vault_access_policy" "kv_common_adgroup_com_admins" {
+ certificate_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ id = (known after apply)
+ key_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
]
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.KeyVault/vaults/io-p-kv-common"
+ object_id = "12a48460-7d95-4d91-ab0a-1d19008aac2c"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_common_adgroup_com_devs will be created
+ resource "azurerm_key_vault_access_policy" "kv_common_adgroup_com_devs" {
+ certificate_permissions = []
+ id = (known after apply)
+ key_permissions = []
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.KeyVault/vaults/io-p-kv-common"
+ object_id = "7b78851b-c40d-497d-ae7f-596b8f92ecf2"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_common_adgroup_svc_admins will be created
+ resource "azurerm_key_vault_access_policy" "kv_common_adgroup_svc_admins" {
+ certificate_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ id = (known after apply)
+ key_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
]
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.KeyVault/vaults/io-p-kv-common"
+ object_id = "100cb2bb-92d5-40ad-bfa9-1d3c676f13e1"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_common_adgroup_svc_devs will be created
+ resource "azurerm_key_vault_access_policy" "kv_common_adgroup_svc_devs" {
+ certificate_permissions = []
+ id = (known after apply)
+ key_permissions = []
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.KeyVault/vaults/io-p-kv-common"
+ object_id = "300ea154-9984-4712-85e9-3abcb3e42960"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_common_adgroup_wallet_admins will be created
+ resource "azurerm_key_vault_access_policy" "kv_common_adgroup_wallet_admins" {
+ certificate_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ id = (known after apply)
+ key_permissions = [
+ "Get",
+ "List",
+ "Update",
+ "Create",
+ "Import",
+ "Delete",
]
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.KeyVault/vaults/io-p-kv-common"
+ object_id = "d38daf6e-4e65-46d2-a11a-6e016b29fcbc"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
+ "Restore",
+ "Recover",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
# module.key_vault_weu.azurerm_key_vault_access_policy.kv_common_adgroup_wallet_devs will be created
+ resource "azurerm_key_vault_access_policy" "kv_common_adgroup_wallet_devs" {
+ certificate_permissions = []
+ id = (known after apply)
+ key_permissions = []
+ key_vault_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.KeyVault/vaults/io-p-kv-common"
+ object_id = "b2ca23d9-ace5-416d-8132-01d9b002db12"
+ secret_permissions = [
+ "Get",
+ "List",
+ "Set",
+ "Delete",
]
+ storage_permissions = []
+ tenant_id = "7788edaf-0346-4068-9d79-c868aed15b3d"
}
Plan: 20 to add, 0 to change, 0 to destroy.
Warning: Deprecated attribute
on ../_modules/vpn/main.tf line 22, in module "vpn":
22: aad_audience = data.azuread_application.vpn_app.application_id
The attribute "application_id" is deprecated. Refer to the provider
documentation for details.
(and one more similar warning elsewhere)
Warning: Argument is deprecated
with module.azdoa_weu.module.azdoa_snet.azurerm_subnet.this,
on .terraform/modules/azdoa_weu.azdoa_snet/subnet/main.tf line 23, in resource "azurerm_subnet" "this":
23: private_endpoint_network_policies_enabled = var.private_endpoint_network_policies_enabled
`private_endpoint_network_policies_enabled` will be removed in favour of the
property `private_endpoint_network_policies` in version 4.0 of the AzureRM
Provider
(and 11 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now. |
christian-calabrese
approved these changes
Jan 16, 2025
Krusty93
deleted the
CES-584-allineamento-permessi-gruppi-entra-id-io-con-as-is
branch
Krusty93
added a commit
that referenced
this pull request
Jan 16, 2025
Co-authored-by: Krusty93 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
General AD groups are going to be dismissed very soon, so each IO domain AD group needs to get access to common KeyVaults
Major Changes
Add access policies to allow AD groups to access common IO KeyVaults
Dependencies
Testing
Documentation
Other Considerations