-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded terraform modules version for citizen_auth_app fast_login function #947
Upgraded terraform modules version for citizen_auth_app fast_login function #947
Conversation
…zurerm provider version
… into sticky_app_setting_names
…zurerm_linux_web_app
…zurerm_linux_web_app
…op and function_fast_login
b760d07
to
868e599
Compare
|
It looks like a check does not pass, consider keeping PR in draft until all checks pass. |
access_tier = "Hot" | ||
advanced_threat_protection_enable = true | ||
use_legacy_defender_version = true | ||
public_network_access_enabled = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this right? (publicily accessible storage?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it can be removed because it's hardcoded to true in the module itself:
EDIT: It cannot be removed cause it's a required variable
module "storage_account" {
source = "github.com/pagopa/terraform-azurerm-v3.git//storage_account?ref=v7.76.0"
name = coalesce(var.storage_account_name, format("%sst", replace(var.name, "-", "")))
account_kind = var.storage_account_info.account_kind
account_tier = var.storage_account_info.account_tier
account_replication_type = var.storage_account_info.account_replication_type
access_tier = var.storage_account_info.account_kind != "Storage" ? var.storage_account_info.access_tier : null
resource_group_name = var.resource_group_name
location = var.location
advanced_threat_protection = var.storage_account_info.advanced_threat_protection_enable
use_legacy_defender_version = var.storage_account_info.use_legacy_defender_version
public_network_access_enabled = true
tags = var.tags
}
closed because it was a duplicate of #963 |
List of changes
In the scope of citizen_auth_app:
Upgraded the version of the
terraform-azurerm-v3
terraform modules employed in thefast_login
function app fromv6.19.1
tov7.77.0
Motivation and context
When executing a
terraform plan
in thecitizen_auth_app
domain, changes on some proprietary resource tags calledhidden-link
are detected. The intention is to avoid displaying such changes to reduce chaos.The newer version (v7.77.0) of the function_app and function_app_slot modules allows to ignore those changes and avoid displaying them.
Type of changes
Env to apply
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)
How to apply
After PR is approved