Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: P4ADEV-2047 ExportFile download API #27

Merged
merged 18 commits into from
Feb 26, 2025
Merged

feat: P4ADEV-2047 ExportFile download API #27

merged 18 commits into from
Feb 26, 2025

Conversation

pelliccm
Copy link
Collaborator

Description

List of Changes

Motivation and Context

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CHORE - Minor Change (fix or feature that don't impact the functionality e.g. Documentation or lint configuration)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pelliccm pelliccm changed the title [P4ADEV-2047] ExportFile download API feat: P4ADEV-2047 ExportFile download API Feb 18, 2025
@pelliccm pelliccm requested a review from antonioT90 February 18, 2025 14:15
@pelliccm pelliccm requested a review from antonioT90 February 25, 2025 13:39
@pelliccm pelliccm requested a review from antonioT90 February 26, 2025 09:19
antonioT90
antonioT90 requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@antonioT90 antonioT90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix also Sonar warnings

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pelliccm pelliccm merged commit 2308b15 into develop Feb 26, 2025
13 checks passed
@pelliccm pelliccm deleted the P4ADEV-2047-file-share-api-per-download-file-elaborato branch February 26, 2025 15:48
@pelliccm pelliccm restored the P4ADEV-2047-file-share-api-per-download-file-elaborato branch February 27, 2025 14:54
@pelliccm pelliccm deleted the P4ADEV-2047-file-share-api-per-download-file-elaborato branch February 27, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioT90 antonioT90 antonioT90 approved these changes

@antocalo antocalo Awaiting requested review from antocalo antocalo is a code owner

@Benedetta-fabbri Benedetta-fabbri Awaiting requested review from Benedetta-fabbri Benedetta-fabbri is a code owner

@LarissaASLeite LarissaASLeite Awaiting requested review from LarissaASLeite LarissaASLeite is a code owner

@RiccardoGiuliani RiccardoGiuliani Awaiting requested review from RiccardoGiuliani RiccardoGiuliani is a code owner

@MScarsella MScarsella Awaiting requested review from MScarsella MScarsella is a code owner

@ElisKina-dev ElisKina-dev Awaiting requested review from ElisKina-dev ElisKina-dev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pelliccm @antonioT90