fix code-gen #45
Merged
fix code-gen #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqualespica
approved these changes
Jan 24, 2022
| @@ -16,8 +16,8 @@ | |||
| "pretest": "npm-run-all envconfig", | |||
| "test": "jest --coverage --ci --testResultsProcessor jest-sonar-reporter", | |||
| "test:local": "jest --coverage --ci", | |||
| "generate:api": "rm -f swagger.json && wget https://raw.githubusercontent.com/pagopa/pagopa-api-config/main/openapi/swagger.json && sed -i 's/\\\\/\\\\\\\\/g' swagger.json && gen-api-models --api-spec swagger.json --no-strict --out-dir generated/api --request-types --response-decoders --client", | |||
| "macosx:generate:api": "rm -f swagger.json && wget https://raw.githubusercontent.com/pagopa/pagopa-api-config/main/openapi/swagger.json && sed -i '' 's/\\\\/\\\\\\\\/g' swagger.json && gen-api-models --api-spec swagger.json --no-strict --out-dir generated/api --request-types --response-decoders --client", | |||
| "generate:api": "rm -f swagger.json && wget https://raw.githubusercontent.com/pagopa/pagopa-api-config/main/openapi/swagger.json && sed -i 's/\\\\/\\\\\\\\/g' swagger.json && python3 ./convert.py && gen-api-models --api-spec swagger.json --no-strict --out-dir generated/api --request-types --response-decoders --client", | |||
There was a problem hiding this comment.
if this is the better solution to deploy now ok.
But 2 things :
- link issue in to PR desc
- we'd create a task in a story
debito tecnicoto put there . As place for all things to see asap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
This PR fixes a bug in the
code-genlib:library creates a broken client from the swagger when custom
X-Request-Idheader is present. To solve the problem, a python script removes the custom header from the swagger.json file. This works because the header is optional.I opened a issue to code-gen lib: pagopa/openapi-codegen-ts#269
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: