Merge pull request #90 from pagopa/PAGOPA-1566

fix: description mandatory field handling [PAGOPA-1566]
pagopa · Mar 1, 2024 · 30e5463 · 30e5463
2 parents 87c90a4 + 1dd0765
commit 30e5463
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/helm/Chart.yaml b/helm/Chart.yaml
@@ -2,8 +2,8 @@ apiVersion: v2
 name: pagopa-gpd-payments
 description: Microservice that exposes API for payment receipts retrieving and other operations
 type: application
-version: 0.71.0
-appVersion: 0.12.8
+version: 0.72.0
+appVersion: 0.12.8-1-PAGOPA-1566
 dependencies:
   - name: microservice-chart
     version: 2.4.0

diff --git a/helm/values-dev.yaml b/helm/values-dev.yaml
@@ -4,7 +4,7 @@ microservice-chart:
   fullnameOverride: ""
   image:
     repository: ghcr.io/pagopa/pagopa-gpd-payments
-    tag: "0.12.8"
+    tag: "0.12.8-1-PAGOPA-1566"
     pullPolicy: Always
   livenessProbe:
     httpGet:

diff --git a/helm/values-prod.yaml b/helm/values-prod.yaml
@@ -4,7 +4,7 @@ microservice-chart:
   fullnameOverride: ""
   image:
     repository: ghcr.io/pagopa/pagopa-gpd-payments
-    tag: "0.12.8"
+    tag: "0.12.8-1-PAGOPA-1566"
     pullPolicy: Always
   livenessProbe:
     httpGet:

diff --git a/helm/values-uat.yaml b/helm/values-uat.yaml
@@ -4,7 +4,7 @@ microservice-chart:
   fullnameOverride: ""
   image:
     repository: ghcr.io/pagopa/pagopa-gpd-payments
-    tag: "0.12.8"
+    tag: "0.12.8-1-PAGOPA-1566"
     pullPolicy: Always
   livenessProbe:
     httpGet:

diff --git a/openapi/openapi.json b/openapi/openapi.json
@@ -4,7 +4,7 @@
     "title": "PagoPA API Payments",
     "description": "Payments",
     "termsOfService": "https://www.pagopa.gov.it/",
-    "version": "0.12.8"
+    "version": "0.12.8-1-PAGOPA-1566"
   },
   "servers": [
     {

diff --git a/pom.xml b/pom.xml
@@ -13,7 +13,7 @@
 
     <groupId>it.gov.pagopa</groupId>
     <artifactId>payments</artifactId>
-    <version>0.12.8</version>
+    <version>0.12.8-1-PAGOPA-1566</version>
     <name>Payments</name>
     <description>Payments</description>
 

diff --git a/src/main/java/it/gov/pagopa/payments/service/PartnerService.java b/src/main/java/it/gov/pagopa/payments/service/PartnerService.java
@@ -382,7 +382,7 @@ private PaGetPaymentRes generatePaGetPaymentResponse(
     }
 
     responseData.setLastPayment(false); // de-scoping
-    responseData.setDescription(source.getDescription());
+    responseData.setDescription(Optional.ofNullable(source.getDescription()).orElse("NA"));
     responseData.setCompanyName(Optional.ofNullable(source.getCompanyName()).orElse("NA"));
     responseData.setOfficeName(Optional.ofNullable(source.getOfficeName()).orElse(("NA")));
     CtSubject debtor = this.getDebtor(source);
@@ -442,7 +442,7 @@ private PaGetPaymentV2Response generatePaGetPaymentResponse(
     }
 
     responseData.setLastPayment(false); // de-scoping
-    responseData.setDescription(source.getDescription());
+    responseData.setDescription(Optional.ofNullable(source.getDescription()).orElse("NA"));
     responseData.setCompanyName(Optional.ofNullable(source.getCompanyName()).orElse("NA"));
     responseData.setOfficeName(Optional.ofNullable(source.getOfficeName()).orElse(("NA")));