fix: [PIDM-133] Updated openapi ecommerce helpdesk service and mongo indexes #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
5 tasks
pietro-tota
reviewed
Feb 12, 2025
src/domains/ecommerce-app/api/ecommerce-helpdesk-api/v1/_openapi.json.tpl
Show resolved
Hide resolved
pietro-tota
reviewed
Feb 12, 2025
| @@ -2147,6 +2177,9 @@ | |||
| }, | |||
| "timeRange": { | |||
| "$ref": "#/components/schemas/DeadLetterSearchDateTimeRange" | |||
| }, | |||
| "excludeStatuses": { | |||
There was a problem hiding this comment.
what about refactor this field name as statusFilter? (renaming also related objects)
There was a problem hiding this comment.
maybe "skippedStatuses" ?
There was a problem hiding this comment.
we propose an internal survey :) we can refactoring it as excludedStatuses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Motivation and context
Type of changes
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)