Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(queue-rate-alert): increase dynamic threshold to 2% #2791

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

pietro-tota
Copy link
Contributor

List of changes

Increase dynamic threshold to 2% for queue PUT vs DELETE alert in order to reduce false positive alert triggering

Motivation and context

Increase dynamic threshold to 2% for queue PUT vs DELETE alert in order to reduce false positive alert triggering

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@pietro-tota pietro-tota self-assigned this Feb 13, 2025
@pietro-tota pietro-tota requested review from a team as code owners February 13, 2025 11:36
@@ -315,15 +315,15 @@ locals {
"time_window" = 30
"frequency" = 15
"threshold" = 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"threshold" = 10
"threshold" = 20

@pietro-tota pietro-tota merged commit b3e11f5 into main Feb 14, 2025
6 checks passed
@pietro-tota pietro-tota deleted the PIDM-174-queue-alert-rate branch February 14, 2025 09:20
Copy link

🎉 This PR is included in version 1.387.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants