Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix delegations card #1028

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Feature/fix delegations card #1028

merged 3 commits into from
Dec 9, 2024

Conversation

martinaCampoli
Copy link
Contributor

  • Fix cards
  • Added chip for delegator and delegate in agreement table row
  • Removed logic for delegator in useGetAgreementAction and used useGetDelegationsUserRole hook

Comment on lines 37 to 40
const { isDelegator } = useGetDelegationUserRole({
eserviceId,
organizationId: jwt?.organizationId,
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooks cannot be called conditionally, so this hook call must be above line 33

Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
53.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Carminepo2 Carminepo2 merged commit f463d42 into dev Dec 9, 2024
8 of 9 checks passed
@Carminepo2 Carminepo2 deleted the feature/fix-delegations-card branch December 9, 2024 14:57
ruggerocastagnola pushed a commit that referenced this pull request Dec 13, 2024
* Fixed delegation create cards

* Added ByDelegationChip in providerAgreementTableRow + Replaced delegator logic with hook useGetDelegationUserRole in useGetAgreementAction

* Moved hook call before if
ruggerocastagnola pushed a commit that referenced this pull request Dec 13, 2024
* Fixed delegation create cards

* Added ByDelegationChip in providerAgreementTableRow + Replaced delegator logic with hook useGetDelegationUserRole in useGetAgreementAction

* Moved hook call before if
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants