Fixing #40: Support KeyValue #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pajowu/master
pajowu
requested changes
Mar 28, 2021
|
Dear @pajowu , Thanks for your feedback. Please see my reply in the inline comment. |
|
Sorry for the long wait, I added another comment to our inline discussion |
|
Thanks for your reply. If CI does not throw any error, it's ready to be merged from my side. |
|
I'm sorry that the commit history got so messy ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is intended to fix #40 by adding support for the output of keyvalue frames. In addition, there are some small code cleanups. For example: I have removed checking the number of frames in
frame.rs::new. I think there is no case in protobuf where a frame has two different contents and it is only necessary to check for unknown frame contents.Best,
mutlusun