Amend update-builder functionality
#342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the run image is a version, we should update it to match the latest build image version, to keep the stack images in lockstep - The run image does not necessarily need to be set to `latest` or follow the legacy tagging convention we used in the Bionic stacks. - For more information on the "legacy tagging convention", see #81 - Add support for updating run image mirrors
I think that I am comfortable with this assumption as we do not currently market this as a tool we offer but do make it available and because I think that setting a specific run image version is something that is an oddity and will only be done in unique circumstance. |
ForestEckhardt
approved these changes
Jun 17, 2024
robdimsdale
approved these changes
Jun 18, 2024
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| builder.Stack.BuildImage = fmt.Sprintf("%s:%s", buildImage.Name, buildImage.Version) | ||
| if runImage != (internal.Image{}) { |
There was a problem hiding this comment.
I think you need them when comparing an instantiation inline but that could be old news.
There was a problem hiding this comment.
yes they are necessary unfortunately. expected ';', found '{' (typecheck)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows the
jam update-buildercommand to update the run image (and associated run image mirrors) if the run image tag is semantically versioned instead oflatest. There are some use cases (such as not being able to publish tolatest) that make this use case helpful. Prior to this change, this use case caused errors when executing.The PR makes the following choices:
If the run image tag is a semantic version (
x.y.zorx.y.z-suffix), we should update it to match the latest build image version, to keep the stack images in lockstep. This assumes the run/build images of a stack are versioned and released together. I think this is simpler than re-calculating the highest tag version available twice, once for build and once for run.If the builder.toml file has run image mirrors present, update them to the same version as the build/run image if the run image has been updated
Continue to support the "legacy tagging convention" in which tags may have a suffix (like
-cnb), although none of our officially supported Paketo stack images use this mechanism, seeFind latest stack images in semver-tagged repos #81
Checklist