Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix for same Dockerfile bug #72

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Add fix for same Dockerfile bug #72

merged 3 commits into from
Jun 6, 2022

Conversation

sophiewigmore
Copy link
Member

Summary

Resolves #66

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sophiewigmore sophiewigmore requested a review from a team as a code owner June 2, 2022 19:53
ryanmoran
ryanmoran approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@ryanmoran ryanmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophiewigmore
Copy link
Member Author

@brayanhenao can we get your review on this please? It requires stack maintainer approval :)

@sophiewigmore sophiewigmore merged commit c7e4f27 into main Jun 6, 2022
@sophiewigmore sophiewigmore deleted the sw-patch-1 branch June 6, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brayanhenao brayanhenao brayanhenao approved these changes

@robdimsdale robdimsdale robdimsdale approved these changes

@ryanmoran ryanmoran ryanmoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to build stack when build and run Dockerfiles are the same
4 participants
@sophiewigmore @ryanmoran @robdimsdale @brayanhenao