Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not run draft release workflow on branches named v2-<something> #594

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

sophiewigmore
Copy link
Member

@sophiewigmore sophiewigmore commented Aug 12, 2024

Summary

It's common for us to create branches called v2-feature-x, causing pushes to that branch to get picked up by our release automation accidentally. This should resolve that.

With this change, notice that the Create Draft release workflow never ran for this branch v2-update-workflow with these changes - https://github.com/paketo-buildpacks/packit/actions/workflows/create-draft-release.yml?query=branch%3Av2-update-workflow

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@ForestEckhardt ForestEckhardt merged commit 3bc586e into v2 Aug 12, 2024
10 of 11 checks passed
@ForestEckhardt ForestEckhardt deleted the v2-update-workflow branch August 12, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants