Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quarkus-native-image-maven to use more up to date practices and updated to Java 21 #908

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

miller79
Copy link

Summary

The following was changed with the PR:

  • Updated maven.compiler to 21
  • Updated README.md to use BP_MAVEN_ADDITIONAL_BUILD_ARGUMENTS instead of BP_MAVEN_BUILD_ARGUMENTS. This change allows the default values in the build arguments to be used which includes the following:
    • -Dmaven.test.skip=true --no-transfer-progress package
  • Updated README.md to use Java 21
  • Updated README.md the BP_NATIVE_IMAGE_BUILT_ARTIFACT to use a wild card for the runner.jar

Use Cases

Changing from BP_MAVEN_BUILD_ARGUMENTS to BP_MAVEN_ADDITIONAL_BUILD_ARGUMENTS allows the defaults given by BP_MAVEN_BUILD_ARGUMENTS to be utilized for free. If these change in the future, they will be automatically added without having to be aware of these changes.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

- Updated `maven.compiler` to 21
- Updated README.md to use `BP_MAVEN_ADDITIONAL_BUILD_ARGUMENTS` instead
of BP_MAVEN_BUILD_ARGUMENTS. This change allows the default values in
the build arguments to be used which includes the following:
  - `-Dmaven.test.skip=true --no-transfer-progress package`
- Updated README.md to use Java 21
- Updated README.md the `BP_NATIVE_IMAGE_BUILT_ARTIFACT` to use a wild
card for the `runner.jar`
@miller79 miller79 requested a review from a team as a code owner December 10, 2024 18:07
Copy link

CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant