Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceleration limits #1

Merged

Conversation

efernandez
Copy link

No description provided.

@po1
Copy link

po1 commented Nov 7, 2013

A bit of explanation: this patch changes where the acceleration limit enforcer gets the current velocity.
To this point, a call to getVelocity() was made, which can only be successful if the joint provides velocity feedback.
This feedback is not always available. So the proposal here is to change the behavior of the interface to keep the last velocity command in memory instead of querying the joint for its current velocity.

Now my comments:

  • the previous behavior was broken, as it assumed that velocity feedback was available, even when it is not. The new behavior works in both cases, but might not work as good as the old behavior when there is velocity feedback.
  • maybe there should be a mechanism to be able to tell if velocity feedback is available, and to provide with the last known velocity command if there is none, as a backup behavior.

@po1
Copy link

po1 commented Nov 7, 2013

@adolfo-rt

adolfo-rt pushed a commit that referenced this pull request Nov 12, 2013
@adolfo-rt adolfo-rt merged commit 35fbc27 into pal-robotics-forks:fuerte_backport Nov 12, 2013
@adolfo-rt
Copy link

See issue #3 for pending tasks in this respect.

@efernandez efernandez deleted the accel_limits branch November 29, 2013 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants