Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP ActuatorStateHandle inherits interfaces from base classes #3

Closed
wants to merge 1 commit into from

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Mar 19, 2019

Implementation of #2

Todo list includes:

  • Make use of base classes as actual interfaces replacing most (hopefully all) occurences of ActuatorStateHandle in business logic, ideally should be defined / used by RobotHW.
  • Base classes should relate to contents of ActuatorData ((likewise for JointData in the future). Flat structs are nice but to extend it maybe needs a templatized version?

@jordan-palacios please add any other items you see fit

@bmagyar
Copy link
Member Author

bmagyar commented Mar 28, 2019

classtransmission__interface_1_1_actuator_to_joint_effort_handle__coll__graph

@bmagyar
Copy link
Member Author

bmagyar commented Mar 28, 2019

The doxygen tools are very good but we need a more mixed view of what's happening.
In the above I think we could replace the transmissionhandle with a more scope-specific handle. This questions whether ActuatorToJointEffortHandle is needed at all since that conceptually stands for the same at that point

@bmagyar bmagyar mentioned this pull request Apr 17, 2019
5 tasks
@bmagyar
Copy link
Member Author

bmagyar commented Apr 17, 2019

Closing in favour of #6

@bmagyar bmagyar closed this Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant