remove bounds check on input 'long' values into 'alias: double' (#2421)

remove bounds check on input 'long' values into 'alias: double'
palantir · Dec 3, 2024 · 4b9f6ce · 4b9f6ce
1 parent 52d48fd
commit 4b9f6ce
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 18 deletions.
diff --git a/changelog/@unreleased/pr-2421.v2.yml b/changelog/@unreleased/pr-2421.v2.yml
@@ -0,0 +1,5 @@
+type: improvement
+improvement:
+  description: 'remove bounds check on input ''long'' values into ''alias: double'''
+  links:
+  - https://github.com/palantir/conjure-java/pull/2421
diff --git a/conjure-java-core/src/integrationInput/java/com/palantir/product/AliasedDouble.java b/conjure-java-core/src/integrationInput/java/com/palantir/product/AliasedDouble.java
diff --git a/conjure-java-core/src/integrationInput/java/com/palantir/product/DoubleAliasExample.java b/conjure-java-core/src/integrationInput/java/com/palantir/product/DoubleAliasExample.java
diff --git a/conjure-java-core/src/integrationInput/java/com/palantir/product/SafeDoubleAliasExample.java b/conjure-java-core/src/integrationInput/java/com/palantir/product/SafeDoubleAliasExample.java
diff --git a/...a-core/src/integrationInput/java/test/prefix/com/palantir/product/DoubleAliasExample.java b/...a-core/src/integrationInput/java/test/prefix/com/palantir/product/DoubleAliasExample.java
diff --git a/...re/src/integrationInput/java/test/prefix/com/palantir/product/SafeDoubleAliasExample.java b/...re/src/integrationInput/java/test/prefix/com/palantir/product/SafeDoubleAliasExample.java
diff --git a/conjure-java-core/src/main/java/com/palantir/conjure/java/types/AliasGenerator.java b/conjure-java-core/src/main/java/com/palantir/conjure/java/types/AliasGenerator.java
@@ -20,7 +20,6 @@
 import com.google.common.collect.ImmutableList;
 import com.palantir.conjure.java.ConjureAnnotations;
 import com.palantir.conjure.java.Options;
-import com.palantir.conjure.java.lib.SafeLong;
 import com.palantir.conjure.java.util.Javadoc;
 import com.palantir.conjure.java.util.Packages;
 import com.palantir.conjure.java.util.Primitives;
@@ -148,8 +147,7 @@ public static JavaFile generateAliasType(
 
         if (isAliasOfDouble(typeDef)) {
             CodeBlock longCastCodeBlock = CodeBlock.builder()
-                    .addStatement("long safeValue = $T.of(value).longValue()", SafeLong.class)
-                    .addStatement("return new $T((double) safeValue)", thisClass)
+                    .addStatement("return new $T((double) value)", thisClass)
                     .build();
 
             CodeBlock intCastCodeBlock = CodeBlock.builder()