do not attempt to generate a dialog service if no endpoints (#2237)

Skips generating the Endpoints enum if no endpoints.
palantir · Mar 18, 2024 · 9db84b2 · 9db84b2
1 parent 828fb8c
commit 9db84b2
Show file tree

Hide file tree

Showing 15 changed files with 356 additions and 4 deletions.
diff --git a/changelog/@unreleased/pr-2237.v2.yml b/changelog/@unreleased/pr-2237.v2.yml
@@ -0,0 +1,5 @@
+type: fix
+fix:
+  description: do not attempt to generate a dialog service if no endpoints
+  links:
+  - https://github.com/palantir/conjure-java/pull/2237
diff --git a/...e/src/main/java/com/palantir/conjure/java/services/dialogue/DialogueServiceGenerator.java b/...e/src/main/java/com/palantir/conjure/java/services/dialogue/DialogueServiceGenerator.java
@@ -82,9 +82,13 @@ public Stream<JavaFile> generate(ConjureDefinition conjureDefinition) {
                 StaticFactoryMethodType.BLOCKING);
 
         return conjureDefinition.getServices().stream()
-                .flatMap(serviceDef -> Stream.of(
-                        endpoints.endpointsClass(serviceDef),
-                        interfaceGenerator.generateBlocking(serviceDef, blockingGenerator),
-                        interfaceGenerator.generateAsync(serviceDef, asyncGenerator)));
+                .flatMap(serviceDef -> !serviceDef.getEndpoints().isEmpty()
+                        ? Stream.of(
+                                endpoints.endpointsClass(serviceDef),
+                                interfaceGenerator.generateBlocking(serviceDef, blockingGenerator),
+                                interfaceGenerator.generateAsync(serviceDef, asyncGenerator))
+                        : Stream.of(
+                                interfaceGenerator.generateBlocking(serviceDef, blockingGenerator),
+                                interfaceGenerator.generateAsync(serviceDef, asyncGenerator)));
     }
 }
diff --git a/conjure-java-core/src/test/resources/example-service.yml b/conjure-java-core/src/test/resources/example-service.yml
@@ -278,3 +278,12 @@ services:
           strings:
             type: set<AliasedString>
             param-type: query
+  TestEmptyService:
+    name: Empty Test Service
+    package: com.palantir.another
+    default-auth: header
+    base-path: /testEmptyService
+    docs: |
+      This service has no endpoints.
+
+    endpoints: {}
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.jersey b/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.jersey
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.jersey.jakarta b/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.jersey.jakarta
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.jersey.prefix b/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.jersey.prefix
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.jersey_require_not_null b/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.jersey_require_not_null
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.undertow b/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.undertow
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.undertow.prefix b/conjure-java-core/src/test/resources/test/api/TestEmptyService.java.undertow.prefix
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyServiceAsync.java.dialogue b/conjure-java-core/src/test/resources/test/api/TestEmptyServiceAsync.java.dialogue
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyServiceAsync.java.dialogue.prefix b/conjure-java-core/src/test/resources/test/api/TestEmptyServiceAsync.java.dialogue.prefix
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyServiceBlocking.java.dialogue b/conjure-java-core/src/test/resources/test/api/TestEmptyServiceBlocking.java.dialogue
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyServiceBlocking.java.dialogue.prefix b/conjure-java-core/src/test/resources/test/api/TestEmptyServiceBlocking.java.dialogue.prefix
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyServiceEndpoints.java.undertow b/conjure-java-core/src/test/resources/test/api/TestEmptyServiceEndpoints.java.undertow
diff --git a/conjure-java-core/src/test/resources/test/api/TestEmptyServiceEndpoints.java.undertow.prefix b/conjure-java-core/src/test/resources/test/api/TestEmptyServiceEndpoints.java.undertow.prefix