Equals compares collections last

[schlosna]

Before this PR

When evaluating equals(Object), collection types are compared before other relative cheaper fields.

After this PR

==COMMIT_MSG==
Equals compares collections last
==COMMIT_MSG==

Possible downsides?

[changelog-app]

Generate changelog in changelog/@unreleased

Type
See change types. Select one:

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Equals compares collections last

Check the box to generate changelog(s)

• Generate changelog entry

[carterkozak]

I wonder if we could pass through the original conjure type information so that we can avoid regressions if we eventually specialize the field types?

[schlosna]

We could potentially pipe the List<EnrichedField> through and use a DefaultTypeVisitor to determine if field should be treated as a collection. It might be worth piping something like List<Pair<EnrichedField, FieldSpec>> through to ensure proper association between the two.

[schlosna]

Right now this is still just a raw WIP I wanted to brain dump as I was digging through a few JFR and saw some conjure types equals methods evaluating java.util.Collections$UnmodifiableSet.equals(Object).

There are some places where we might want to just manually reorder fields in yaml, but was thinking we could defer collection comparison to short-circuit in case of mismatches.