Replacing SimpleTemplateEngine with basic string replace to improve performance in mergeProperties #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erformance in mergeProperties
| into.setProperty(property, propertyValue) | ||
| int end = str.indexOf('}', begin) | ||
| if (end < 0) { | ||
| sb.append(str.substring(start)) |
There was a problem hiding this comment.
should this be an error case?
There was a problem hiding this comment.
Do you mean should this throw an error? Or account for this situation in a try/catch block? indexOf will return -1 if the character isn't present and not an error, so it'd only hit a catch block if we manually throw an error.
There was a problem hiding this comment.
No, I'm wondering if this case should generate an exception. In other words, when we encounter a string huihi ${foobar lalala, should we silently leave it as is, or throw an error?
There was a problem hiding this comment.
Ah I understand. Exception has been added in most recent commit.
|
Thanks! |
|
will be available as 0.7.2 |
|
Sweet, thanks @uschi2000 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against our Emcee project (which has 97 projects).
./gradlew eclipseruntime drops from 4 minutes to 40 seconds.