Fix ovc enrollment && discontinuation validations (#183)

Co-authored-by: Makombe <makombe>
palladiumkenya · Sep 6, 2023 · 5fed95c · 5fed95c
1 parent ea3ebd6
commit 5fed95c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/configuration/ampathforms/OVC_Discontinuation.json b/configuration/ampathforms/OVC_Discontinuation.json
@@ -76,6 +76,7 @@
 							"label": "Exit Reasons",
 							"type": "obs",
 							"id": "discontinuationReason",
+							"required": "true",
 							"questionOptions": {
 								"concept": "161555AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA",
 								"rendering": "select",

diff --git a/configuration/ampathforms/OVC_Enrollment.json b/configuration/ampathforms/OVC_Enrollment.json
@@ -174,7 +174,7 @@
 							"validators": [
 								{
 									"type": "js_expression",
-									"failsWhenExpression": "(myValue).length > 10 || (myValue).length <10",
+									"failsWhenExpression": "!isEmpty(myValue) &&  (myValue).length !==10",
 									"message": "Phone number digits should be equal to 10"
 								}
 							],
@@ -216,13 +216,7 @@
 								"concept": "165416AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA",
 								"showDate": "false"
 							},
-							"validators": [
-								{
-									"type": "js_expression",
-									"failsWhenExpression": "(myValue).length > 7 || (myValue).length < 7",
-									"message": "CPIMS unique identifier digits should not be more or less than 7"
-								}
-							],
+							"validators": [],
 							"hide": {
 								"hideWhenExpression": "enrolledCpims != '1065AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA'"
 							}