ETL for Orthopaedic form #488
Open
+883
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel090
force-pushed
the
KHP3-6835
branch
from
1d4b663 to
81b721b
Compare
njorocs
requested changes
Dec 16, 2024
| e.voided as voided | ||
| from encounter e | ||
| inner join person p on p.person_id=e.patient_id and p.voided=0 | ||
| inner join form f on f.form_id=e.form_id and f.uuid in ("beec83df-6606-4019-8223-05a54a52f2b0") |
There was a problem hiding this comment.
use "=" instead of in for single value comparison
| date_created DATETIME NOT NULL, | ||
| date_last_modified DATETIME, | ||
| visit_type INT(11), | ||
| referral_form INT(11), |
| e.date_created as date_created, | ||
| max(if(o.concept_id=164181,trim(o.value_coded),null)) as visit_type, | ||
| max(if(o.concept_id=161643,trim(o.value_coded),null)) as referral_form, | ||
| max(if(o.concept_id=160632,o.value_text,null)) as other_facility_name, |
There was a problem hiding this comment.
This concept is repeated in the form multiple times. Using it here may report the wrong data
| musculoskeletal_system_conditions_other VARCHAR(255), | ||
| musculoskeletal_examination_findings VARCHAR(255), | ||
| musculoskeletal_findings INT(11), | ||
| musculoskeletal_findings VARCHAR(255), | ||
| musculoskeletal_findings_other VARCHAR(255), | ||
| joint_assessed VARCHAR(255), | ||
| joint_movement INT(11), |
There was a problem hiding this comment.
Data type mismatch between ddl and dml
| max(if(o.concept_id = 164936 and o.value_coded = 135412, 'Anterior/posterior angulation',NULL)), | ||
| max(if(o.concept_id = 164936 and o.value_coded = 134186, 'Garden spade deformity',NULL)), | ||
| max(if(o.concept_id = 164936 and o.value_coded = 116472, 'Kyphosis',NULL)), | ||
| max(if(o.concept_id = 164936 and o.value_coded = 5622, 'Others',NULL))) as musculoskeletal_findings, | ||
| max(if(o.concept_id=160632,o.value_text,null)) as musculoskeletal_findings_other, | ||
| max(if(o.concept_id=165285,o.value_coded,null)) as joint_assessed, | ||
| max(if(o.concept_id=165139,o.value_coded,null)) as joint_movement, |
| musculoskeletal_system_conditions_other VARCHAR(255), | ||
| musculoskeletal_examination_findings VARCHAR(255), | ||
| musculoskeletal_findings INT(11), | ||
| musculoskeletal_findings VARCHAR(255), | ||
| musculoskeletal_findings_other VARCHAR(255), | ||
| joint_assessed VARCHAR(255), | ||
| joint_movement INT(11), |
There was a problem hiding this comment.
This won't handle multi-select. Check data type.
| max(if(o.concept_id = 164936 and o.value_coded = 135412, 'Anterior/posterior angulation',NULL)), | ||
| max(if(o.concept_id = 164936 and o.value_coded = 134186, 'Garden spade deformity',NULL)), | ||
| max(if(o.concept_id = 164936 and o.value_coded = 116472, 'Kyphosis',NULL)), | ||
| max(if(o.concept_id = 164936 and o.value_coded = 5622, 'Others',NULL))) as musculoskeletal_findings, | ||
| max(if(o.concept_id=160632,o.value_text,null)) as musculoskeletal_findings_other, |
There was a problem hiding this comment.
Same concept used for musculoskeletal_examination_findings above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create ETL for Orthopaedic Technology (Prosthetics and Orthotics) Register MOH 420