New makefile #17
Merged
New makefile #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. A single root makefile for everything: library, examples, tests 2. Introduce makefile variables for all compilation flags 3. Add comments to explain the -Wl,-E 4. Use "install" instead of "cp", to set correct permissions. 5. Can run tests without "make install", using local ptracer.h and pt-run. Fixes #11 ps.: The new filenames changed all the tracebacks. Can we change the tests so that they don't break so easily?
singul4ri7y
reviewed
Aug 9, 2024
If there is a compilation error, then there's no point in running the tests.
This way do do not need a -I compilation flag to find the ptracer.h and we don't need to discuss what is the name of the include directory.
It's a bad idea to run the compiler with sudo, and it's not what people expect.
It was causing the CI to fail, because that's part of -Wextra for them? Fixes #18
singul4ri7y
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Fixes #18
ps.: The new filenames changed all the tracebacks. Can we change the tests so that they don't break so easily?