Updated the translator to use gsub("%S", "") instead of `gsub("%S",…
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomg
requested changes
Aug 6, 2020
itssamuelrowe
force-pushed
the
update_translator
branch
from
f3f9bf1
to
5dfd8f2
Compare
hugomg
requested changes
Aug 7, 2020
pallene/translator.lua
Outdated
| -- Remove the type annotation but exclude the next token. | ||
| self:add_whitespace(decl.type.loc.pos, decl.end_loc.pos - 1) | ||
| -- self:add_whitespace(decl.type.loc.pos, decl.end_loc.pos - 1) |
There was a problem hiding this comment.
These 3 comments are now outdated. We could just remove them.
itssamuelrowe
force-pushed
the
update_translator
branch
from
5dfd8f2
to
eca2bbd
Compare
… " ")` Fixes issue #277. If we remove the non-whitespace characters instead of simply replacing them with spaces it produces a more pleasant-looking output. For example, ``` function f(x: integer) ``` becomes ``` function (x) ``` instead of ``` function f(x ) ``` Column numbers are not be preserved but line numbers are. This is okay because Lua error messages do not show column numbers, they only show line numbers.
itssamuelrowe
force-pushed
the
update_translator
branch
from
eca2bbd
to
c12cb87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… " ")`
Fixes issue #277. If we remove the non-whitespace characters instead of simply replacing them with
spaces it produces a more pleasant-looking output. For example,
becomes
instead of
Column numbers are not be preserved but line numbers are. This is okay because Lua error messages
do not show column numbers, they only show line numbers.