Improved stack trace in Pallene using Pallene Tracer #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singul4ri7y
changed the title
hugomg
reviewed
May 31, 2024
hugomg
changed the title
hugomg
reviewed
May 31, 2024
hugomg
reviewed
May 31, 2024
hugomg
reviewed
May 31, 2024
hugomg
reviewed
May 31, 2024
hugomg
reviewed
May 31, 2024
hugomg
reviewed
May 31, 2024
srijan-paul
previously requested changes
Jun 1, 2024
|
I have committed another change which fixes/enhances to the code in matter. One problem I think we got, is the Pallene tracer line number is not quite correct. Any insights on this? @hugomg @srijan-paul |
hugomg
reviewed
Jun 5, 2024
| fprintf(stderr, "Runtime error: %s\nStack traceback: \n", message); | ||
|
|
||
| /* Lua: 1, Pallene: 0 */ | ||
| int context = 1; |
There was a problem hiding this comment.
I wonder if we can structure our traversal as two nested loops and get rid of the context flag and some of the gotos.
for each frame in the Lua stack
if this frame is linked to the Pallene stack
for each frame in the Pallene stack block
print C frame
else
print Lua frame
Changes were addressed / srijan is on sick leave
hugomg
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commits on Pallene Tracer implementation in Pallene compiler for improved stack-traces using a separate debug traceback function
pallene_tracer_debug_traceback.The Pallene Tracer initial design specification can be found here: The Pallene Tracer
Resolves #565