Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass status code to the exception created in Aborter #2794

Closed
wants to merge 1 commit into from

Conversation

lkk7
Copy link

@lkk7 lkk7 commented Oct 3, 2023

This PR sets the code attribute in the HTTPException raised by Aborter, in the Response handling case. This code attribute was missing.

Please do correct me on the CHANGES.rst change as there is no "unreleased version" entry and I didn't know where to put that.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@lkk7 lkk7 closed this Oct 3, 2023
@lkk7 lkk7 deleted the add-status-code-to-exception branch October 3, 2023 12:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Aborter class does not set the code attribute on the exception it raises if it receives a Response
1 participant