-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _reloader.py #2823
Update _reloader.py #2823
Conversation
When is path empty? This needs a reproducing example. |
https://cloud.google.com/anthos/run/archive/docs/tutorials/image-processing I don't know the specific cause, but it seems to depend on the difference in containers in the execution environment. windows10 docker desctop Skaffold only occurs while debugging. |
I just disabled debug mode because of the same issue. Paths are taken from
|
I can also reproduce this from docker:
|
BTW, the bug plays out like this:
|
root={} path=() os.path.join(*path) Traceback (most recent call last): File "<string>", line 1, in <module> TypeError: join() missing 1 required positional argument: 'path'
I've encountered a
TypeError
in the_find_common_roots
function within the_reloader.py
module, specifically triggered whenos.path.join(*path)
is called with an emptypath
tuple.\werkzeug_reloader.py 161
root={}
path=()
os.path.join(*path)
Traceback (most recent call last):
File "", line 1, in
TypeError: join() missing 1 required positional argument: 'path'
Checklist:
CHANGES.rst
summarizing the change and linking to the issue... versionchanged::
entries in any relevant code docs.pre-commit
hooks and fix any issues.pytest
andtox
, no tests failed.