restrict containers accepted by multi #2995
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inlining the type annotations, I noticed that
iter_multi_items
and related methods were annotated to acceptcollections.abc.Iterable
, but actually calledisinstance(value, (list, tuple)
. I expanded this toisinstance(value, Container) and not isinstance(value, str)
. However, this incorrectly matched and iterated overbytes
,bytearray
,memoryview
,array
, etc, all of which should be treated as single values. Rather than trying to build up an allow list, I've gone back to restricting to(list, tuple, set)
, addingset
since it was the one built-in collection type missing that would make sense to use.fixes #2994